Use EscapeFormula() in CSV export
#11901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
snipe
changed the title
EscapeFormula() in CSV export
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
EscapeFormula()method built into the CSV exporter to escape Excel formulas, which in general is good practice, HOWEVER, some folks might be using formulas as fields on purpose, so I've also included an.envoverride so that admins can override this behavior if they need to. This value defaults to true ifCSV_ESCAPE_FORMULASis set totrueor or not set at all in the.env(which would be common for people upgrading who never added it to their.env.)This addresses the low-severity CSV injection huntr.dev report here reported by @Vautia, which does not seem to be reproducible in Excel or LibreOffice, just OpenOffice (so far.)