Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error 500 when downloading asset acceptance report. [sc-19555] #11906

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Oct 3, 2022

Description

When looking at the Unaccepted Assets report, if the user click on the Download All button, an exception occurs because it's trying to got into a relationship that doesn't exist if the unaccepted item is not an asset (accessory, consumable, etc), so I filter those types from the downloaded report so it matches to the on-screen one.

Fixes [sc-19555] and freshdesk ticket 30941

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@inietov inietov changed the base branch from master to develop October 3, 2022 23:19
@snipe snipe merged commit e9224f0 into snipe:develop Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants