Overhaul of UI for unprivileged users #11908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
snipe
changed the title
uberbrady
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
This looks excellent! I think the overall visual style is better - long sections that are broken out in a big page-scrolly thing is generally going to obscure information more than having tabs with nice badges on them. I threw a few tiny little nits about some minor stylistic issues, but regardless, this is great and I'd love to see it.
I wonder if a weird side-effect is that we might see some of our administrators not wanting to prevent logins to view their own profile quite so much? That'd be nice!
Anywhoo - this looks awesome and I approve!
Signed-off-by: snipe <snipe@snipe.net>
uberbrady
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues our process of trying to compact some of these UI sections, while still being limited enough to not expose functionality or elements that would link to things the user viewing their profile doesn't have access to do (so no sad pandas.)
Before
After