Added start and end dates to users #11926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
uberbrady
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
This sounds like it could be a useful feature for a lot of people - and I love the idea that, eventually, we might even be able to take actions based on what's here - like if someone is past their end_date, and they have things assigned to them - then that might be something we need to handle, somehow. I had a couple of minor stylistic points I raised, but not enough to block the PR. Thanks for making this, and I can't wait to see what our users do with it!
| @@ -343,6 +343,30 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| <!-- start date --> | |||
| @if ($user->start_date) | |||
| <div class="row"> | |||
There was a problem hiding this comment.
Tiny teensy microscopic nit - can we indent the innards of the @if directive?
There was a problem hiding this comment.
I already merged that, but I did apply that indent directly to develop
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds a start date and end date to users and includes the ability to search/sort on those dates via API.
Fixes FD-10911 and SC-9356