Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new scim-trace feature from our fork of laravel-scim-server lib #11927

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

uberbrady
Copy link
Collaborator

We have had a lot of SCIM issues of late, which have been hard to track down. This change enables us to use the newest version of our own fork of the laravel-scim-server library, which now has a scim-tracing feature which will write (almost) every single request and response that comes from SCIM into its own log file. (Requests against non-existent resources still will get caught at the routing layer, due to route-model binding, so we can't catch those just yet. But they will show up in laravel.log and will be pretty apparent).

@snipe had expressed some concerns about whether or not we would have to add the new scim.log file to the .gitignore - but it's not showing up as changed on my local so that seems fine already. She also talked about the idea of adding an empty scim.log file to the ./storage/logs directory - but I fear this is going to make the file be 'tracked by git' so I'm going to not add that just yet. But if you have the Linux chops to be able to twiddle the .env to add your SCIM_TRACE variable to it, then you can just as easily do a touch on that file, I figure.

If it turns out that this latest change to the composer.lock file actually blows things up, we can just do a simple revert and it should pull us back to the prior release, so that should keep us relatively safe.

@uberbrady uberbrady requested a review from snipe as a code owner October 6, 2022 00:51
@snipe snipe merged commit 25e4b7d into snipe:develop Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants