Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Depreciation date diff readable precision #11959

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Oct 12, 2022

Description

Working with dates is tricky, the correct date diff in the Asset's view is something like "2 years, 10 months, 10 days from now", but the function we are using from the Carbon library only reports back the year part. So I added a parameter to return a little more precise string.

Fixes internal freshdesk 31184

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@snipe
Copy link
Owner

snipe commented Oct 12, 2022

Perfect, thank you!

@snipe snipe merged commit 3f105cd into snipe:develop Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants