Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #12095 - email logo still linking even if settings deny it #12127

Conversation

deloz
Copy link
Contributor

@deloz deloz commented Nov 16, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context, providing screenshots where practical. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Nov 16, 2022

  • The condition for the image to be displayed in email was changed.
  • If show_images_in_email is set to 1, then only display images in emails else don't display them at all.

@deloz deloz changed the title Fixed: 12095 Fixed: #12095 Nov 16, 2022
@snipe snipe changed the title Fixed: #12095 Fixed #12095 - email logo still linking even if settings deny it Nov 16, 2022
@snipe snipe requested a review from inietov November 16, 2022 15:53
@snipe
Copy link
Owner

snipe commented Nov 16, 2022

@inietov I think this might overlap with your current open PR - do you want me to merge this one and then have you resolve conflicts in yours and re-push?

@inietov
Copy link
Collaborator

inietov commented Nov 16, 2022

@snipe Yes please 🙏🏽

@snipe snipe merged commit 3ac92e1 into snipe:develop Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants