Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added serial column to the user history page #12141

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

Godmartinz
Copy link
Collaborator

Description

adds the serial column to the action logs in the users history. It is defaulted as not visible.

image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Nov 17, 2022

  • Added a new field to the ActionlogsTransformer.php file
  • Updated view.blade.php with two fields, one of which is hidden by default

@snipe
Copy link
Owner

snipe commented Nov 17, 2022

Looks great! One tiny nit - can you pull out that extra line break between the <th> tags?

@Godmartinz
Copy link
Collaborator Author

done!

@snipe snipe changed the title adds serial column to the action logs Added serial column to the action logs Nov 17, 2022
@snipe snipe changed the title Added serial column to the action logs Added serial column to the user history page Nov 17, 2022
@snipe
Copy link
Owner

snipe commented Nov 17, 2022

May as well add it to the Activity Report too, I'd think?

@Godmartinz
Copy link
Collaborator Author

also done 🙂

@snipe
Copy link
Owner

snipe commented Nov 17, 2022

Great, thanks!!

@snipe snipe merged commit f0c5560 into snipe:develop Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants