Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated installer script for multiple fixes and features #12158

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

subdriven
Copy link
Contributor

Description

Multiple fixes for the installer script including fixes noted below, added support for new Debian, Ubuntu, and Rocky Linux distributions as well as checks for now EOL or unsupported OSes. Refactored some of the script to fix logging and display issues.

Fixes # (issue)
Fixed #10581 installer does not work on CentOS7
Fixed #10105 php not found, composer failed
Fixed #9035 CentOS 7 IUS repos missing
Fixed #9844 Can't install on CentOS 8
Fixed #9724 Fresh install from installer gives permission error
Fixed #8750 Clean install using install script fails with error

(and probably some others)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Created a virtual machine of each OS, clean install with minimal default installations. Tested against every OS listed:

  • CentOS 6 (EOL, script checks for this)
  • CentOS 7
  • CentOS 8
  • CentOS 9
  • Debian 9
  • Debian 10
  • Debian 11
  • Fedora 36 (latest at time of testing)
  • Rocky 8
  • Rocky 9
  • Ubuntu 14.04.6
  • Ubuntu 18.04.6
  • Ubuntu 20.04.5
  • Ubuntu 21.10
  • Ubuntu 22.04.1

Checklist:

Fixed snipe#10581: installer does not work on CentOS7
Fixed snipe#10105: php not found, composer failed
Fixed snipe#9035: CentOS 7 IUS repos missing
@welcome
Copy link

welcome bot commented Nov 22, 2022

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@snipe snipe requested a review from uberbrady November 28, 2022 21:15
@snipe
Copy link
Owner

snipe commented Dec 19, 2022

Why are we changing the case for distro names here? I'd expect that to potentially interfere with people's workflows if they're not expecting it. Ideally it would be case insensitive.

@subdriven
Copy link
Contributor Author

Because the wording was used in notices to the user and was trying to make it look better. Easy enough to revert w/o causing issues.

@snipe snipe merged commit 0db83ad into snipe:master Jan 10, 2023
@welcome
Copy link

welcome bot commented Jan 10, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@snipe
Copy link
Owner

snipe commented Jan 10, 2023

Ack - that PR was merged into master. In the future, please always branch from develop and put your PR up against the develop branch, per the developer docs.

If the case-sensitivity ends up being an issue, we can always fix it if it's messing folks up.

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants