Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #12046 #12137 Custom field checkboxes not holding value for develop #12166

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Nov 23, 2022

Description

Same as #12165, but for develop branch

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Nov 23, 2022

  • The code was refactored to use the array_map function instead of preg_split.
  • A space character is added after each comma in order for trim() to work properly on it, and then removed again afterwards with implode().

@snipe snipe merged commit 11a1ab9 into snipe:develop Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants