Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #12161 500 error when accepting assets #12168

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Nov 24, 2022

Description

When a user tries to accept an assigned asset, if no MAIL_REPLYTO_ADDR environment variable is setted in their .env file, the system shows a 500 error because the return type of the function routeNotificationForMail() is a string.

This PR I checks first if the variable is setted and if it is, returns the address, if don't exists just returns an empty string so the system don't crash.

Fixes #12161

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@snipe snipe merged commit d226cf1 into snipe:develop Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants