Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rollbar integration if ROLLBAR_TOKEN is provided #12329

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jan 10, 2023

This is a possible improvement/fix for #11989.

Signed-off-by: snipe <snipe@snipe.net>
@what-the-diff
Copy link

what-the-diff bot commented Jan 10, 2023

  • The return statement was changed to a variable assignment
  • A new channel called 'rollbar' was added, which uses the Rollbar monolog handler and sets its level based on an environment variable (ROLLBAR_LEVEL)
  • If there is a ROLLBAR_TOKEN in the .env file, then we add rollbar as one of our channels for stack logging

@snipe snipe requested a review from jerm January 10, 2023 08:21
@snipe snipe mentioned this pull request Jan 10, 2023
2 tasks
Copy link
Collaborator

@jerm jerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better! It sends rollbars when there's a token, and doesn't break when there isn't one! :-D

@snipe
Copy link
Owner Author

snipe commented Jan 11, 2023

👍

@snipe snipe merged commit 2eac03d into develop Jan 11, 2023
@snipe snipe deleted the fixes/rollbar_integration branch January 11, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants