Redo SCIM config; use latest laravel-scim-server from our fork #12341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, I feel pretty good about this, let me see if I can fix up these conflicts |
uberbrady
force-pushed
the
redo_scim_config
branch
from
064f157
to
c5d3b3a
Compare
|
(And it's fair for you to ask me "Well then test it you silly person! And tell me the results". But I don't want to. Because I'm lazy.) |
|
Okay, I tested this branch on my local against Okta and it seems okay. I'm going to add one more BIG CHANGE - changing the default to be 'true' for the SCIM_COMPLIANCE setting - I haven't heard anyone complain about it, and you can still set it to |
|
Okay, that's added. This is good to go. |
|
Nice work, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enough of our SCIM configuration that 'overrode' the default one got to the point where it's easier and better to just simply re-define it in full, rather than just define our 'overrides'. So this does that. Furthermore, we have pushed an update to our fork of laravel-scim-server, and this picks up the latest hash for that latest commit. This should help with Okta integration, which has had problems with the PUT requests that update any enterprise attributes.