-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed file uploads for accessories, components, and consumables #12370
Merged
snipe
merged 11 commits into
snipe:develop
from
marcusmoore:fix/file-upload-tab-permissions
Jan 19, 2023
Merged
Fixed file uploads for accessories, components, and consumables #12370
snipe
merged 11 commits into
snipe:develop
from
marcusmoore:fix/file-upload-tab-permissions
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty to upload files for accessories
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This PR is gorgeous - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the previously missing file upload tab and file upload button on the accessories, components, and consumables show pages for users that have the ability to view and modify files for those respective entities. For non-super-users this means the following permissions have been granted:
This is accomplished by registering the gates that are already being checked in the templates:
accessories.files
components.files
consumables.files
In addition, minor template changes were made on the accessory show page so the bottom bar is constrained to the content area, and the layout is consistent for users regardless of if they have access to accessory files.
Type of change
Before and After
Assuming the user has been granted the "View and Modify x Files" mentioned above.
Accessories
Components
Consumables