Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #12340 Deleting imported files visually drops first element in table. #12377

Merged

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Jan 19, 2023

Description

Add index value to deleteFile() function call in import-blade view, so it knows what element delete from the files array in the frontend.

Fixes #12340

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.2
  • MySQL version: 8.0.31
  • Webserver version: N/A
  • OS version: Debian 11

@what-the-diff
Copy link

what-the-diff bot commented Jan 19, 2023

  • The v-for directive was changed to include the index of each file in files.
  • In deleteFile, currentFile is now passed as a parameter along with its index so that it can be removed from the array using splice().

@snipe snipe merged commit 04e28c2 into snipe:develop Jan 19, 2023
@snipe
Copy link
Owner

snipe commented Jan 19, 2023

Excellent work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants