Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dev assets #12380

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Updated dev assets #12380

merged 1 commit into from
Jan 19, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jan 19, 2023

On the tin - expect a master PR or merge soon

Signed-off-by: snipe <snipe@snipe.net>
@what-the-diff
Copy link

what-the-diff bot commented Jan 19, 2023

  • The first diff is a change in the signature-pad.min.css file
  • It changed from one line to 135 lines of code, which means that it was minified and then unminified
  • This could be done by using an online tool or manually doing so with your text editor (I used sublime)
  • The background color of the header was changed from Reduce emphasis on asset name #111 to transparent.
  • The sidebar menu item hover and active colors were changed from #1e282c, border-left-color: Reduce emphasis on asset name #111; to
    color: var(--hover-link);, background: none; respectively.
  • A new class called .search-highlight was added with a yellow highlight for search results in the admin panel's table view (see screenshot below).
  • The background color of the header was changed from #3c8dbc to unset.
  • The text-color for links in the sidebar menu were changed from #b8c7ce to var(--link).
  • The background color of the header was changed from #3c8dbc to unset.
  • The text-color for links in the sidebar menu were changed from #b8c7ce to var(--link).
  • The background color of the navbar was changed from #001f3f to #00060c
  • The text color in the dropdown menu for mobile devices was changed from white (#fff) to black (#000).
  • The background color of the navbar was changed from #001f3f to transparent.
  • The text color in the sidebar menu header was changed from #4b646f to white (#fff).
  • The background color of the navbar was changed from #00a65a to transparent.
  • The text color in the sidebar menu header was changed from #4b646f to white (#fff).
  • The background color of the navbar was changed from #00a65a to transparent.
  • The text color in the sidebar menu header was changed from #4b646f to white (#fff).
  • The background color of the header was changed from #ff8c00 to none.
  • The text-color in the navbar was changed from white to black (Add assetlog to Deployed Loading #333).
  • A new class called .btn-white:link and :hover were added with a background color of #cc7000, which is lighter than before (the old one had a value of #b36200)
  • In addition, there are some changes made on colors for visited links and hover links as well as button default/primary/hover values that can be seen at line 205 - 209 above
  • The background color of the header was changed from #ff8c00 to none.
  • The text color in the sidebar menu was changed from white (#fff) to black (Add assetlog to Deployed Loading #333).
  • A new class called .search-highlight, which changes a search result's background colour when hovered over, has been added with a value of #e9d15b (yellowish brown).
  • The background color of the header was changed from #605ca8 to none.
  • The text color in the sidebar menu was changed from #b8c7ce to white (#fff).
  • A new variable called --light-link: #fff; has been added, which is used for links that are on a light background (e.g., footer) and should be visible against it when they're not hovered over or active/focused on by keyboard navigation etc.. This will make them more accessible than if we just use var(--nav-link), as this would mean all non-hovered/non-active links were invisible against a light background unless you hover over them with your mouse cursor first!
  • The background color of the header was changed from #605ca8 to transparent.
  • The sidebar menu's hover and active colors were changed from white (#fff) to a light gray (#f6f6f6).
  • A new variable called --light-link was added with value #FFF (white). This is used in the navbar dropdown menus for links that are hovered over or clicked on, as well as when an item is selected in a table row using checkboxes/radio buttons.
  • In addition, there are many other changes made throughout this diff file which include: changing font sizes; adding padding around elements such as tables; removing borders between rows within tables; etc... These changes seem minor but they do affect how things look visually so I think it would be best if we kept them all together instead of separating out each change into its own commit message since these types of commits can get very long and tedious quickly! We could also consider splitting up some larger chunks like "changing font size" into smaller ones based off what typeface family they belong too - e..g., sans serif vs monospace fonts." For example: "Changed Sans Serif Font Size From 12px To 14px". But again, this might not always make sense depending on context!"
  • The background color of the navbar was changed from #dd4b39 to transparent.
  • The text color in the sidebar menu header was changed from #fff to #4b646f, and its background-color was also changed from none to #1a2226;
  • In .sidebar-menu > li:hover > a,.skin-red .sidebar-menu > li.active > a,the border left width is now 3px instead of 1px;
  • The background color of the navbar was changed from #dd4b39 to transparent.
  • The text color in the sidebar menu header was changed from #fff to #4b646f, and its background-color was also changed from none to 1a2226.
  • In .sidebar-menu > li:hover > a, .sidebar-menu > li:active>a,.skin-red .sidebar-menu>li>.treeview_menuside bar menu list item hover active tree view menuthe border left width is now 3px instead of 0px;
  • The background color of the navbar was changed from #fbcc34 to transparent.
  • The text color in the sidebar menu header was changed from white (#fff) to a dark gray (#4b646f).
  • A new class called .text-primary with a yellowish orange hex code value of #c59704 has been added for use as an alternative primary text color option throughout the application, which is currently being used on some buttons and links (e.g., "Add New" button at top right corner of page when viewing all users or roles). This change also includes adding this variable into :root so that it can be referenced by other classes/components if needed later on down the road without having to go back through each file where it's used and update them individually again manually every time we want to make changes going forward; instead, we just have one place now where we need only update once whenever necessary moving forward: --button-default: #deab04; --> --button-default: var(--link);
  • The background color of the navbar was changed from #fbcc34 to transparent.
  • The text color for links in the sidebar menu were changed from white to black, and then back again (to white).
  • A new class called .text-primary was added with a hex value of #c59704 as its font colour property value. This is used on line 539: {{ $count }}
  • The file was changed from public/mix-manifest.json to public/mix-manifest.json
  • There are 24 lines in the old version and 24 lines in the new version of this file
  • In line 1, there is a change from { to { (no space)
  • In line 2, there is a change from /js/build/app...d9c0da90153.." to "/js....f05cc05b900..." (the id has been updated)
    5./css.....392cc93cfc0be034... -> f677207c6cf96.. (id update for skin blue css)

@snipe snipe merged commit 69ab42b into develop Jan 19, 2023
@snipe snipe deleted the maintenance/asset_updates branch January 19, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant