Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: translations for EULA Acceptance Summary #12398

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Jan 23, 2023

Description

The blades that show the acceptance of eula print out a few lines in a summary. This PR adds translation functioning to that little bit of detail on those blades.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Jan 23, 2023

  • Added a new translation key to the general.php file
  • Updated all of the views that use this key with it's value from the translations file

@akemidx akemidx changed the title Acceptance translations Fixed: translations for EULA Acceptance Summary Jan 23, 2023
@akemidx akemidx changed the base branch from master to develop January 23, 2023 22:18
@akemidx
Copy link
Collaborator Author

akemidx commented Jan 23, 2023

i forgot to switch it to merge into develop. I have edited it to do that, but am unsure if its kicked off any weird processes and missed any of the ones we usually have.

@snipe
Copy link
Owner

snipe commented Jan 24, 2023

This is great, thanks Jes :)

@snipe snipe merged commit 690bfbe into snipe:develop Jan 24, 2023
@akemidx akemidx deleted the acceptance_translations branch April 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants