Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed buttons colors in high contrast theme #12405

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description

Fixes a couple buttons not appearing in the high contrast theme
image
image

Fixes # SC-14590

Type of change

Please delete options that are not relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Jan 24, 2023

  • Added a new class to the skin-contrast.less file
  • Changed color of link in navbar from white to navy blue
  • Removed underline on hover for links in navbar

@snipe snipe changed the title fixes a couple buttons color choices in high contrast theme Fixed buttons colors in high contrast theme Jan 24, 2023
Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Godfrey! I think this was also happening with the blue dark skin as well - can we squeeze that one into this PR too?

@Godmartinz
Copy link
Collaborator Author

image

image

Dark Themes look like this already 👍 @snipe

@snipe
Copy link
Owner

snipe commented Jan 24, 2023

That's possible :)

Birgit Zeus Jan 19 2023, 8:05 am
Partially still valid.
Cancel button on "Create New" asset screen is not visible on "High Contrast" color setting
Custom Export button is barely visible on All Assets page, when high contrast is selected

@snipe
Copy link
Owner

snipe commented Jan 24, 2023

Looks good, thanks Godfrey!

@snipe
Copy link
Owner

snipe commented Jan 24, 2023

Except it's against master.... can you retarget to develop?

@Godmartinz Godmartinz changed the base branch from master to develop January 24, 2023 23:16
@Godmartinz
Copy link
Collaborator Author

Done! my bad 😄

@snipe snipe merged commit 935f501 into snipe:develop Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants