Resolved Rollbar error 16746 - missing array key 'extension'

[uberbrady]

So we've been getting a lot of these Rollbar errors lately - "missing array key 'extension'"

It turns out that pathinfo() doesn't even return the extension on files that don't have one. While doing an array_key_exists() call is always an option, it turns out there's a flag we can pass that will make it return the extension instead. So I used that.

I confirmed the bug by doing:

php artisan tinker
Psy Shell v0.11.7 (PHP 7.4.33 — cli) by Justin Hileman
>>> pathinfo('fart')['extension']
PHP Notice:  Undefined index: extension in /Users/uberbrady/Documents/grokability/snipe-iteval()'d code on line 1
=> null

>>> pathinfo('fart', PATHINFO_EXTENSION)
=> ""

>>> 

I tested this by running a CLI restore on my local, which worked.

[what-the-diff]

• The pathinfo function was changed from using the array syntax to use the constant PATHINFO_EXTENSION
• This change is made because PHP 7 deprecated support for accessing elements of an associative array with square brackets, and instead recommends that you access them by their key name (https://www.php.net/manual/en/migration70.incompatible.php#migration70.incompatible-core).

PHP: Backward incompatible changes - Manual

[snipe]

Looks great - thanks Brady!