Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Invalid date value on assets acceptance mail notification #12433

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Jan 30, 2023

Description

The date acceptance data that is passed to the notification was being generated wrong as it used to take the format that the app have set to show in the interface. This PR pass the needed dates as YYYY-MM-DD always, and then the mail notification is shown as the user have it configured.

Fixes internal freshdesk 32971

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.2
  • MySQL version: 8.0.31
  • Webserver version: PHP development Server
  • OS version: Debian 11

@what-the-diff
Copy link

what-the-diff bot commented Jan 30, 2023

  • Changed the date format from $branding_settings->date_display_format to 'Y-m-d'
  • Added a new line in the declined email template with {{declined_date}}

@snipe snipe merged commit 2d45ebe into snipe:develop Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants