FIXED: Translations on the User Creation setup page #12447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This looks perfect - it's saying there are conflicts though? |
|
Oh, I think that the ending ]; was missing when i created the branch? maybe from my mistroking or typing? I am unsure, because it looked clean on my side when I submitted the PR. A glance at the 'resolve conflicts' makes it look liek it doesn't like that i moved that closing bracket? I don't have enough experience to really guess further. |
snipe
reviewed
Feb 2, 2023
resources/views/setup/user.blade.php
Outdated
| @parent | ||
| @stop | ||
|
|
||
| {{-- Page content --}} | ||
| @section('content') | ||
|
|
||
| <p> This is the account information you'll use to access the site for the first time. </p> | ||
| <p>{{ trans('admin/user/general.create_user_page_explaination') }}</p> |
There was a problem hiding this comment.
This is a small detail, but I think there's a typo in this key - "explaination" vs "explanation"
|
Ping! I'd love to get this into v6.1.0. <3 |
|
should be all set |
svpernova09
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translations have been added to the rest of the Create User page
Checklist: