Fixed Rollbar 16883 Error: Attempt to assign property "assigned_to" on null #12470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the License Importer, we try to get a free license seat to assign as required, but if we don't have any the system fails with
Attempt to assign property "assigned_to" on null
error. This PR takes care of that adding a guard clause to return early if no empty seat is found, ignoring that assignation.We can make the system to fail if no empty license seat is found, but looking at the code I understood that the Importer ignores the assignation if no seat is found and I thought this makes the Importer consistent in both error cases (no seats left or no empty seat found). Let me know if you think it's better to return the error instead.
Fixes Rollbar 16883
Type of change
How Has This Been Tested?
Test Configuration: