Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to Apple Warranty link #12477

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Feb 7, 2023

Added functionality to the Apple warranty checker offered on the asset details page.
The click through icon will now show up if other terms such as "Apple Inc." are used, instead of a model being restriced to only "Apple" (case sensitive). This new functionality also removed the case sensitive requirement.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally in test instance. passed boolean values tested:
Apple = true
Apple Inc. = true
Apple Incorporated = true
Appleton Heavy Industries = false

Test Configuration:

  • PHP version: 8.1

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Feb 7, 2023

  • Added a check for the manufacturer name to be "Apple" or start with "appleinc".
  • If it is, then add an Applecare Status Lookup link next to the warranty expiration date.

@snipe snipe merged commit 2bbbc81 into snipe:develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants