Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed awkward checkout text in checkedout side panel #12521

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Feb 15, 2023

Description

When checking out an asset, and no asset assigned to the user selected, the page was trying to add the user's name into a line stating no assets assigned for that user. This was bugged and this PR removes that bit of code to make the line read correctly.

Fixes SC-19909

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

tested locally with new wording

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Feb 15, 2023

  • The first diff changes the text of a table header from "Current Assets" to "Assets Assigned".
  • The second diff removes the name of the user in question and replaces it with generic text.

@snipe snipe changed the title FIXED: 19909: Weird checkout text Fixed awkward checkout text in checkedout side panel Feb 15, 2023
@snipe
Copy link
Owner

snipe commented Feb 15, 2023

Looks good! Any chance we can get that into a translations file tho?

@akemidx
Copy link
Collaborator Author

akemidx commented Feb 15, 2023

of course!

@snipe
Copy link
Owner

snipe commented Feb 16, 2023

noice-key-and-peele-ixu6

Thank you!

@snipe snipe merged commit 51c9a7d into snipe:develop Feb 16, 2023
@akemidx akemidx deleted the weird_checkout_text branch April 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants