Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes slack settings submit button availability #12523

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description

This greys out the submit button if slack_endpoint or slack_channel are not filled in. Also greys it out if the integration
test fails or hasn't been run.
Fixes #SC-20041

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Feb 15, 2023

  • Added a new variable $isDisabled to the class SlackSettingsForm.php
  • Updated function render() in SlackSettingsForm.php, added if statement that checks whether slack_channel and slack_endpoint are empty or not, then sets isDisabled accordingly
  • Updated function testSlack(), set isDisabled='' when success message appears
  • Changed button type submit from disabled to {{$isdisabled}} in view file slack-settings-form blade php

@snipe snipe changed the title fixes slack settings submit button availability Fixes slack settings submit button availability Feb 16, 2023
@snipe snipe merged commit df64e0e into snipe:develop Feb 16, 2023
@Godmartinz Godmartinz deleted the bug/sc-20041/slack-ui-livewire-tweaks branch February 16, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants