Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly close tag in mail template #12550

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR properly closes a th tag.

With this change the Name label is presented as expected as well.

Before After
Before After

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally by checking out a license to a user and running php artisan snipeit:user-inventory and checking the results in MailTrap.

@what-the-diff
Copy link

what-the-diff bot commented Feb 23, 2023

  • The trans() function was missing a closing parenthesis.
  • A space between the align="left" and {{ trans('mail.name') }} attributes in the tag was removed, which caused an error when rendering this email template as HTML (the browser would render it as if there were no spaces).

@snipe snipe merged commit 4a9ced1 into snipe:develop Feb 23, 2023
@snipe
Copy link
Owner

snipe commented Feb 23, 2023

Awesome, great sleuthing - tysm for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants