Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds General option to the webhooks settings #12570

Merged
merged 10 commits into from
Mar 13, 2023

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Feb 27, 2023

Description

adding a general option for webhooks, we don't test integrations on this, but it allows users to add fields if they did work before the slack validation was added. renames most variables and translation strings to webhook instead of slack (naturally).

General Option:
image
Slack Option:
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Feb 27, 2023

  • Added a new variable called $integration_app to the SlackSettingsForm.php file
  • Changed all instances of 'Slack' in the slack-settings-form blade template and lang files to use this new variable instead
  • Created an array with key value pairs for different integration options, which are then used as selectable options on the form (currently only has one option)
  • Updated some other variables that were hardcoded or not being set correctly

@probot-autolabeler probot-autolabeler bot added the dependencies Pull requests that update a dependency file label Mar 13, 2023
@Godmartinz Godmartinz changed the title WIP Adding options to the webhooks settings Adds General option to the webhooks settings Mar 13, 2023
@Godmartinz Godmartinz marked this pull request as ready for review March 13, 2023 17:56
@Godmartinz Godmartinz requested a review from snipe as a code owner March 13, 2023 17:56
Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the alignment and spacing with that top dropdown button?

@Godmartinz
Copy link
Collaborator Author

Changes applied and pictures have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dependencies Pull requests that update a dependency file frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants