Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Address in mailbox given does not comply with RFC 2822, 3.6.2. [sc-202022] #12574

Merged

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Feb 27, 2023

Description

When the user accepts/declines an asset if the setting alert_email is set, and that value is formed of multiple emails comma separated, the system fails.

To fix this issue I convert that string value into an array of strings (emails) on the CheckoutAcceptance model function that return those addresses.

Fixes shortcut sc-20202 and rollbar 16977

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.2
  • MySQL version: 8.0.31
  • Webserver version: PHP Dev Server
  • OS version: Debian 11

@what-the-diff
Copy link

what-the-diff bot commented Feb 27, 2023

  • The routeNotificationForMail() method was changed to return an array of recipients instead of a single recipient.
  • This change is necessary because the alert_email setting can now contain multiple email addresses separated by commas, and we need to send notifications for each address in that list.

@snipe snipe merged commit 23fe11c into snipe:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants