Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the sidebar margin top #12579

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description

Adjusts the sidbar menu's top margin so that it clears the nav header and all buttons are clickable for all media sizes.
image

Fixes #12571

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Feb 28, 2023

  • The margin-top of the sidebar menu was changed for different screen sizes.
  • For screens smaller than 512px, it is now 160px instead of 64px.
  • For screens between 772 and 1098 pixels wide, it is 98 px instead of 51 px (the original value).

@snipe
Copy link
Owner

snipe commented Feb 28, 2023

That seems like too much of a margin tho? Dashboard should fit cleanly under the hamburger, IMHO

@snipe snipe merged commit 44e2796 into snipe:develop Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants