Added vip and byod to importer
#12624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
|
Signed-off-by: snipe <snipe@snipe.net>
snipe
changed the title
vip and byod to importer
marcusmoore
approved these changes
Mar 6, 2023
Signed-off-by: snipe <snipe@snipe.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the backend and front-end (and sample CSVs) to include the newly added
vipflag on the user importer and the newly addedbyodon the asset importer. The vue stuff won't matter once #12587 is merged, but this should work until then.I might have missed something here though, as the test import I ran didn't seem to apply the correct values forvipas a boolean.Edit: It seems like we were not selecting or searching on the
vipin the Users API controller and it was not in the users transformer, which was causing it to show as false in the listing UI. It was actually be imported correctly.