Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain asset name during import with checkout #12628

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Maintain asset name during import with checkout #12628

merged 1 commit into from
Mar 7, 2023

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR fixes an issue where asset names were not being populated (or being removed) when importing assets that are checked out (have a check out location defined in the import).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@marcusmoore marcusmoore requested a review from snipe as a code owner March 7, 2023 19:17
@what-the-diff
Copy link

what-the-diff bot commented Mar 7, 2023

  • The method checkOut() was changed to accept two more parameters: notes and name.
  • In the line where this method is called, we can see that these new parameters are passed as null values (line 137).

@snipe snipe merged commit e399015 into snipe:develop Mar 7, 2023
@marcusmoore marcusmoore deleted the fixes/keep-asset-name-on-import branch March 7, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snipe snipe Awaiting requested review from snipe snipe is a code owner

Assignees
No one assigned
Labels
backend importer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcusmoore @snipe