-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #12607 - Datestamp on "Print All Assigned" generated form #12636
Fixed #12607 - Datestamp on "Print All Assigned" generated form #12636
Conversation
This pull request has been linked to Shortcut Story #20330: Date on All Assigned PDF. |
|
Maybe, you could add the time too, so it is clear, when exactly this view was created? |
Great, thank you!👍🏻 |
@akemidx Is it red irl, or just for your screenshot? |
It is formatted to be red in the file itself |
Do we want that to be red though? I feel like it should maybe be at the bottom of the page in normal text style? And we should probably use the date format the admin has picked in the Admin Localization settings. |
The demo was in red, but it can be black. I was hesitant to put it at the bottom in case it could be confused for the "signed" date. But, absolutely we should use the local selected date settings. |
<br> | ||
<br> | ||
//needs to fix string/int error | ||
<div style='text-align:left'><div style='color:black'>{{ trans('admin/users/general.all_assigned_list_generation')}} {{ date('d-M-Y H:i', $currenttime) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we try not to inject PHP into blades where we can help it, especially to create a one-off variable that we don't use anywhere else in the blade. Also if we're using the Helper::getFormattedDateObject()
, that helper method is going to format it as the user wants it to appear. When you use the date()
formatter, you're going to override that.
{{ Helper::getFormattedDateObject(now(), 'date', false) }}
should suffice IMHO
Perfect, thank you! <3 |
Thank you for this! I really appreciate your work! |
Description
Added a datestamp onto the form generated when a user selects "Print All Assigned" from the user detail view window. It is calling the users local time, so will stay relevant to where the user is when they generate the form.
Date formatting is chosen to improve usability around the world as different date formats are common.
Type of change
How Has This Been Tested?
Tested locally.
Test Configuration:
Checklist:
Fixes #12607