Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #12647: fix translation and adds icon on property reassignable #12648

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Fixed #12647: fix translation and adds icon on property reassignable #12648

merged 1 commit into from
Mar 10, 2023

Conversation

floschoepfer
Copy link
Contributor

Description

Fixes #12647
On the individual license pages, the property Reassignable is not translated and the icon (red cross or green checkmark) is missing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Not tested.

Checklist:

@welcome
Copy link

welcome bot commented Mar 10, 2023

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@what-the-diff
Copy link

what-the-diff bot commented Mar 10, 2023

  • Changed the reassignable field to use icons instead of text.

@snipe
Copy link
Owner

snipe commented Mar 10, 2023

Nice fix, thank you!

@snipe snipe merged commit 58d2e65 into snipe:develop Mar 10, 2023
@welcome
Copy link

welcome bot commented Mar 10, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@floschoepfer floschoepfer deleted the patch-1 branch March 13, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants