Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small visual tweaks to slack/webhook UI #12667

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Mar 14, 2023

These are just some small tweaks - possibly not the last - for the new Livewire webhook form. @Godmartinz - as far as I know, this doesn't break anything new. (See the video in Slack) It just cleans up some of the HTML. We were missing (and I may not have hit them all) some aria label/accessibility stuff, etc. I just wanted to put this out there so you could work from this and not have a giant mess of conflicts to deal with later today.

Signed-off-by: snipe <snipe@snipe.net>
@what-the-diff
Copy link

what-the-diff bot commented Mar 14, 2023

  • Added a new option to the dropdown menu for Slack and Discord
  • Changed some of the text in general.php from "Slack" to "$webhook_selected" so that it can be used with both apps
  • Updated slack-settings-form blade file, added an if statement around webhook channel input field (line 57) because this is not needed when using discord integration
  • Removed unnecessary code on line 61 - 64 as well as lines 67 - 70 since they are no longer needed due to changes made above

@snipe snipe merged commit b839802 into develop Mar 14, 2023
@snipe snipe deleted the fixes/small_livewire_ui_fixed branch March 14, 2023 16:47
@snipe snipe changed the title Small UI tweaks Small visual tweaks to slack/webhook UI Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant