Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Consumable Factory Seeder #12672

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Mar 14, 2023

Description

As with other items, the Consumable seeder was silently failing because of the purchase date format. This PR added the expected format, so now the seeder can create consumables to test.

Fixes N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ ]

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.2
  • MySQL version: 8.0.31
  • Webserver version: PHP dev server
  • OS version: Debian 11

@what-the-diff
Copy link

what-the-diff bot commented Mar 14, 2023

  • Changed the purchase_date from a datetime object to a string

@snipe snipe requested a review from marcusmoore March 14, 2023 23:51
Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏾

@snipe snipe merged commit a991bdd into snipe:develop Mar 15, 2023
@marcusmoore marcusmoore mentioned this pull request Mar 15, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants