Fixed Undefined array key 266 rollbar 17086 #12720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user have a lot of status labels to show in the dashboard's pie chart (the one above), if the statuses are more than the colors we have by default (266) the pie chart doesn't show because of this index out of range.
I don't know if it's the proper solution, but I just added a condition to 'restart' the color index, making that the colors repeat from the beginning when show in the pie chart. This makes for 532 statuses, that seems plenty but with enough status labels the system can get to crash again... but I'm unsure how to handle it because I don't know how to return an error to the dashboard...
Fixes rollbar 17086
Type of change
How Has This Been Tested?
Test Configuration: