Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Flight String fixes for step 2 #12747

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Conversation

svpernova09
Copy link
Contributor

Description

Fixes issues with translation strings on Page 2 of Preflight. Discord Link

Before:

image

After:

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Mar 28, 2023

PR Summary

  • 🌐 Added new translation key/value pair
    Updated general.php file to include a new key/value pair for setup_migration_create_user string.

  • 🔄 Updated migrate view template
    Migrate view template now utilizes the new translation instead of the old one.

@svpernova09 svpernova09 changed the title Preflight strings Pre-Flight String fixes for step 2 Mar 28, 2023
@snipe
Copy link
Owner

snipe commented Mar 28, 2023

Awesome, TY Joe! <3

@snipe snipe merged commit e03a961 into snipe:develop Mar 28, 2023
@svpernova09 svpernova09 deleted the preflight-strings branch March 28, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants