Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes translation strong for "group not found" error #12753

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Mar 28, 2023

This corrects the language string that displays when a group is not found, and also switches to use a user icon in the header to make it more consistent with the rest of the Snipe-IT UI.

Before:

Screenshot 2023-03-28 at 4 36 28 PM

After:

Screenshot 2023-03-28 at 4 36 21 PM

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@what-the-diff
Copy link

what-the-diff bot commented Mar 28, 2023

PR Summary

  • 🚀 Improved error message for missing groups
    The error message now includes the ID of the missing group for easier identification.
  • 🔍 New icon for user count
    A new icon displays the number of users associated with each group, making it visually more appealing.
  • 🌐 Enhanced translation function
    An extra parameter has been added to trans() function calls for better handling of translation strings and associated variables.

@snipe snipe merged commit c9d1274 into develop Mar 28, 2023
@snipe snipe changed the title Fixes/lang for group not found Fixes translation strong for "group not found" error Mar 28, 2023
@snipe snipe deleted the fixes/lang_for_group_not_found branch July 12, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant