Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CrowdIn configuration to allow nested translations #12782

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR updates the app's CrowdIn configuration so that directories are included when Building and Downloading translations from CrowdIn's UI.

Currently, the generated zip file only contains the .php files at the top level of each language directory.
current output

With this PR, the directories for each language, account, admin, and auth, are included when the translations are built and downloaded:
output with this PR

Note: the issue where the most of the resulting translations are keyed by locale (en-US instead of en) is still present and will be addressed in the near future.

@marcusmoore marcusmoore requested a review from snipe as a code owner April 4, 2023 22:49
@what-the-diff
Copy link

what-the-diff bot commented Apr 4, 2023

PR Summary

  • Updated Source File Path in Crowdin
    The source file path has been updated to allow for more efficient language translations. This change lets us easily add more content in the future without needing manual updates.

  • Added Comment about Placeholders in Crowdin Config
    A helpful comment has been added to explain what placeholders can be used in the Crowdin configuration file, providing a useful reference for users. Crowdin Placeholder Documentation

@snipe snipe merged commit 2e45c43 into snipe:develop Apr 5, 2023
3 checks passed
@marcusmoore marcusmoore deleted the chore/update-crowdin-config branch April 5, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants