Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for available quantity on consumables before checkout #12802

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Apr 7, 2023

This should handle the edge case where two people are hitting the consumables UI/API at the same time and trying to check out something that doesn't have enough left to allocate a consumable to the last user.

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 1ee1cf1 into develop Apr 7, 2023
3 checks passed
@snipe snipe deleted the fixes/consumables_checkout_when_0_qty branch April 7, 2023 03:40
@what-the-diff
Copy link

what-the-diff bot commented Apr 7, 2023

PR Summary

  • Enhanced translation string for consumable availability
    Added a new translation string to handle cases when there are not enough consumables left for the checkout process.

  • Updated ConsumableCheckoutController
    Improved the create() and store() methods to check the availability of at least one consumable before allowing users to proceed with the checkout process, displaying an error message if the condition isn't met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant