Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added invalid parse to dontReport #12826

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Apr 12, 2023

Since we're trapping those errors and handling them via the exception handler, we don't need to send those to the logs, etc.

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 1a7201d into develop Apr 12, 2023
3 checks passed
@snipe snipe deleted the fixes/added_invalid_parse_to_dont_report branch April 12, 2023 15:28
@what-the-diff
Copy link

what-the-diff bot commented Apr 12, 2023

PR Summary

  • Improved error handling for date formatting
    The InvalidFormatException is now properly addressed in the render method of Handler.php
  • Limited date input in License model
    Added a maximum length of 10 characters to date fields (purchase_date, expiration_date, and termination_date) to prevent invalid dates being entered
  • Enhanced license edit view
    Updated the edit view for licenses by limiting the input length for "expiration_date" using the maxlength="10" attribute - this prevents users from accidentally entering incorrect date formats
  • Updated datepicker template
    Adjusted the datepicker blade template by adding maxlength="10" attribute to prevent incorrect date inputs

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the front-ey-endy parts of this aren’t really going to help with the problem - as badly-behaved clients aren’t going to respect the limits anyways. But the limitations at the validation level might help. Worth a shot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants