Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dark themes pagination and notification drop menu #12828

Merged
merged 8 commits into from
Apr 17, 2023

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Apr 13, 2023

Description

Fixes all dark themes' pagination from white/blue to fit into the theme.
image
Screenshot 2023-04-12 at 3 28 33 PM
Screenshot 2023-04-12 at 3 32 03 PM
Screenshot 2023-04-12 at 3 34 51 PM
Screenshot 2023-04-12 at 3 27 35 PM
Screenshot 2023-04-12 at 3 27 16 PM

Also fixes the notification menu for dark themes
Screenshot 2023-04-12 at 4 01 06 PM

Fixes #12805 SC-20783

Type of change

Please delete options that are not relevant.

issue)

  • New feature (non-breaking change which adds functionality)
  • [ X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #20783: Black dark mode pagination wrong color.

@what-the-diff
Copy link

what-the-diff bot commented Apr 13, 2023

PR Summary

  • Improved pagination styles for dark themes
    Added pagination styles suitable for dark skins to enhance user experience.
  • Fixed tasks menu background color in skin-green-dark
    Resolved an issue with the background color of the tasks menu for better consistency with the theme.
  • Updated header text color in navbar dropdown menus
    Changed header text color to link color in navbar dropdown menus for all themes except yellow and green for better readability.
  • Enhanced active page button and hover effect
    Changed the active page button style to the theme's primary button style and improved the hover effect for better visibility and interaction.

@Godmartinz Godmartinz marked this pull request as ready for review April 13, 2023 18:04
@Godmartinz Godmartinz requested a review from snipe as a code owner April 13, 2023 18:04
@snipe
Copy link
Owner

snipe commented Apr 17, 2023

That dark red text on dark grey isn't really readable - can we make that white instead?

@Godmartinz
Copy link
Collaborator Author

@snipe Red buttons are fixed 👍

@Godmartinz Godmartinz changed the title WIP Fixes dark themes pagination and notification drop menu Fixed dark themes pagination and notification drop menu Apr 17, 2023
@snipe
Copy link
Owner

snipe commented Apr 17, 2023

Looks great, thanks @Godmartinz!

@snipe snipe merged commit c70cb36 into snipe:develop Apr 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Green (Dark Mode) Skin displays items below minimum incorrect in the messages popup
2 participants