Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added supplier to components and consumables #12830

Merged
merged 14 commits into from
Apr 16, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Apr 13, 2023

This fixes #7795. Adds supplier ID to the consumables and components tables, and displays components and consumables in the suppliers view.

snipe added 14 commits April 13, 2023 11:03
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@what-the-diff
Copy link

what-the-diff bot commented Apr 13, 2023

PR Summary

  • Added supplier_id and relationship to components and consumables
    The components and consumables tables now have a supplier_id column, and a relationship has been created between these models and the suppliers model.

  • API endpoints and transformers updated
    API endpoints for ComponentsController, ConsumablesController and SuppliersController have been updated. Also, ComponentTransformer, ConsumableTransformer, and SupplierTransformer have been updated to handle new changes.

  • Factories and migration file updated
    Factories for component and consumable models have been updated with new fields. A migration file has been created to add the new columns.

  • Improved edit views and category select
    Edit views for components, consumables, and accessories have been updated with better supplier information. The category select has been enhanced for use beyond assets, now supporting consumables/components.

  • New tab for components and consumables
    A new tab has been introduced for components and consumables, making it easier to manage these items.

  • Updated view for asset counts in categories
    The view has been updated to display the number of assets in each category for components and consumables.

@rkthamizhan
Copy link

rkthamizhan commented Apr 14, 2023

Suppliers not shown
oz5powgi

After added Supplier 500 Server error

@rkthamizhan
Copy link

rkthamizhan commented Apr 14, 2023

after appended above all coding, in Component tab i can see the supplier but not in
Consumables. and all exisiting supllier information got disappered
And try to edit Component tab and add supplllier information it shows "500 server error" after click the save button

@snipe
Copy link
Owner Author

snipe commented Apr 14, 2023

after appended above all coding

Never do this. Just wait for the PR to be merged so you can be sure it's thoroughly tested. My guess is that you didn't run migrations.

@rkthamizhan
Copy link

after appended above all coding

Never do this. Just wait for the PR to be merged so you can be sure it's thoroughly tested. My guess is that you didn't run migrations.

yes im not run the migration, pls assist me with the executable command..thanks

@rkthamizhan
Copy link

hi i revoked all the changes (restored from snapshot)..
now i can't import csv files shows error "500 server error" on the latest version -Version v6.1.0 - build 10161 (master)

@snipe snipe merged commit 9555398 into develop Apr 16, 2023
3 checks passed
@snipe snipe deleted the features/adds_supplier_id_to_components branch April 16, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow components to be mapped to a supplier
2 participants