-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed footer space when customized #12832
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still seems a little brittle to me. I'd think it shouldn't need to be hard-coded, but would instead increase as the number of lines increase, especially since that section takes some amount of markdown, IIRC
Ok, I'll see what I can conjure up 👍 |
Went with display:flex and now it dynamically adjusts with the size of the footer content or media size. |
shoot. 1 sec found a visual bug 🙁 |
Ok the support footer text aligns to the right, as it should. |
@else | ||
<footer class="main-footer hidden-print"> | ||
@endif | ||
<div class="pull-text-right hidden-xs"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to actually hide this on xs
breakpoints?
Signed-off-by: snipe <snipe@snipe.net>
This is already merged, but I may have to revert it. It's making the spacing at the bottom way too big. See SC-23134 |
Description
Footer would be covered up by the div wrapper if the footer went more than one line. I added display:grid to the footer to stack the support info, the Snipe-it Link and the footer.
I created another css class
pull-text-right
because thepull-right
was not working in this case. The footer dynamically grows with the size of a custom footer messageBEFORE:
AFTER:
Fixes #SC-15580
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: