Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed footer space when customized #12832

Merged
merged 5 commits into from
Apr 18, 2023
Merged

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Apr 13, 2023

Description

Footer would be covered up by the div wrapper if the footer went more than one line. I added display:grid to the footer to stack the support info, the Snipe-it Link and the footer.
I created another css class pull-text-right because the pull-right was not working in this case. The footer dynamically grows with the size of a custom footer message

BEFORE:
image

AFTER:
image

Fixes #SC-15580

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@what-the-diff
Copy link

what-the-diff bot commented Apr 13, 2023

PR Summary

  • Improvement to the footer
    Added a conditional statement that adjusts the footer height by 100px if there is text in the snipe settings.

Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still seems a little brittle to me. I'd think it shouldn't need to be hard-coded, but would instead increase as the number of lines increase, especially since that section takes some amount of markdown, IIRC

@Godmartinz
Copy link
Collaborator Author

Ok, I'll see what I can conjure up 👍

@snipe snipe changed the title fixes footer space when customized Fixed footer space when customized Apr 17, 2023
@Godmartinz
Copy link
Collaborator Author

Went with display:flex and now it dynamically adjusts with the size of the footer content or media size.

@Godmartinz Godmartinz requested a review from snipe April 17, 2023 19:03
@Godmartinz
Copy link
Collaborator Author

shoot. 1 sec found a visual bug 🙁

@Godmartinz
Copy link
Collaborator Author

Ok the support footer text aligns to the right, as it should.

@else
<footer class="main-footer hidden-print">
@endif
<div class="pull-text-right hidden-xs">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to actually hide this on xs breakpoints?

@snipe snipe merged commit c12ac99 into snipe:develop Apr 18, 2023
3 checks passed
snipe added a commit that referenced this pull request Apr 18, 2023
Signed-off-by: snipe <snipe@snipe.net>
@snipe
Copy link
Owner

snipe commented Apr 18, 2023

This is already merged, but I may have to revert it. It's making the spacing at the bottom way too big. See SC-23134

snipe added a commit that referenced this pull request Apr 18, 2023
Signed-off-by: snipe <snipe@snipe.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants