Location importer via Livewire Importer #12846
Conversation
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
PR Summary
|
| $this->importTypes = [ | ||
| 'asset' => trans('general.assets'), | ||
| 'accessory' => trans('general.accessories'), | ||
| 'consumable' => trans('general.consumables'), | ||
| 'component' => trans('general.components'), | ||
| 'license' => trans('general.licenses'), | ||
| 'user' => trans('general.users'), | ||
| 'location' => trans('general.locations'), |
There was a problem hiding this comment.
Nitpick: can we move this up a line so that the options are in alphabetical order?
There was a problem hiding this comment.
I added it to the bottom of the list because it's less common than the others. It's far more common for users to import all of those other first-class objects versus locations, so I was trying to list it by priority, not alphabetical.
Lemme chew on that though.
Co-authored-by: Marcus Moore <contact@marcusmoore.io>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
|
Okay, can we give this another spin please? |
|
I'll take another look tomorrow morning 👍🏾 |
|
Blargh - I think I broke something - not seeing users being created when I test with the assets sample CSV |
|
Actually, no - the sample CSV seems to not have "Checkout Type" in there. I might not have broken it after all. Will explore more tomorrow. |
There was a problem hiding this comment.
I eyed the commits added after my review and it all looks good. I think we can trust my eyes and @spencerrlongg's actual testing right?? 😅
|
Shouldn't the .csv file include a "Parent" field to match the Locations export? |
Okay, I think I've hammered out these details, but it will for sure need a lot of testing, not just from the Location Import side, but also to make sure I didn't break any of the other existing imports. I've tested a LOT, but there will always be funny use cases, of course.
Fixes #8401