Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tooltip improvements for undeployable items in table view #12867

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Apr 18, 2023

Since tooltips for disabled "checkout" buttons were previously not working, we hadn't noticed that the language was a little confusing in the tooltip if the item was not an asset, as it references status labels. This fix localizes the strings, and also carves out a special case for assets.

Before

Screenshot 2023-04-18 at 12 55 09 PM

After

Screenshot 2023-04-18 at 12 55 40 PM

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit a84a9a8 into develop Apr 18, 2023
3 checks passed
@what-the-diff
Copy link

what-the-diff bot commented Apr 18, 2023

PR Summary

  • New translation string for undeployable assets tooltip
    A new tooltip translation string has been added to provide clearer information on assets that cannot be deployed.

  • Updated existing translation string for more generic application
    The existing translation string has been updated to cover not only hardware, but also other items such as accessories.

  • Typo fixes in comments and documentation
    Minor typos in comments and code documentation have been fixed to improve readability and understanding.

@snipe snipe deleted the fixes/clearer_tooltip_text_for_non_assets_undeployable branch April 18, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant