Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a checkout range for custom asset reports #12874

Merged
merged 3 commits into from
May 3, 2023

Conversation

Godmartinz
Copy link
Collaborator

Description

Adds checkout range inputs for custom asset reports.
image

Fixes # 23130

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe as a code owner April 19, 2023 16:14
@shortcut-integration
Copy link

@what-the-diff
Copy link

what-the-diff bot commented Apr 19, 2023

PR Summary

  • Added checkout date range filter
    A new filter has been added to allow users to select a specific date range for checkouts.

  • Updated custom report form
    The custom report form has been updated to include the new checkout date range filter field.

@Godmartinz
Copy link
Collaborator Author

Should it read "Checked out" instead? 🤔

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏾

resources/views/reports/custom.blade.php Outdated Show resolved Hide resolved
@snipe snipe merged commit fe710ef into snipe:develop May 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants