Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an environment variable to set the session cookie path #12877

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

joelpittet
Copy link
Contributor

Description

In production we hang the app off a sub directory, and in local development it's not off a sub directory but a custom domain snipeit.test for example.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

We have a diff where against the latest stable release that gets applied and we use this in production.

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0
  • Webserver version: Apache 2.4
  • OS version: Ubuntu/macOS

@joelpittet joelpittet requested a review from snipe as a code owner April 19, 2023 22:22
@what-the-diff
Copy link

what-the-diff bot commented Apr 19, 2023

PR Summary

  • Configurable Session Cookie Path
    The session cookie path can now be easily customized using the SESSION_COOKIE_PATH environment variable.

@snipe snipe merged commit 7d9062c into snipe:develop Apr 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants