Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment variable and default to PHP's sendmail_path #12878

Merged
merged 1 commit into from
May 3, 2023

Conversation

joelpittet
Copy link
Contributor

@joelpittet joelpittet commented Apr 19, 2023

Use sendmail_path in PHP instead of hardcoded path and options

Description

We use mailhog in our DDEV local development with sendmail and in staging we change the sendmail enviroment variable to dump email in the garbage (/tmp).

Instead of using a hardcoded path and options for the sendmail command you can use an environment variable and default to another environment variable provided by PHP.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

We use this configuration to capture emails in local dev and staging.

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0
  • Webserver version: Apache 2.4
  • OS version: Ubuntu/Redhat/macOS

Checklist:

Use sendmail_path in PHP instead of hardcoded path and options
@joelpittet joelpittet requested a review from snipe as a code owner April 19, 2023 22:30
@what-the-diff
Copy link

what-the-diff bot commented Apr 19, 2023

PR Summary

  • Updated sendmail path
    The sendmail path has been changed to retrieve its value from the environment variable SENDMAIL_PATH or fall back to the sendmail_path value in the PHP configuration file (php.ini). This improves flexibility in configuring the email sending process.

@snipe snipe merged commit cdbd680 into snipe:develop May 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants