Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more granular permissions on bulk actions for assets #12910

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Apr 25, 2023

In a use case where a user only has view permission, if they were trying to create labels, they would get our sad panda permission denied page, since the bulk edit controller was checking for edit permissions, not view permissions. This fixes that.

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit efc0929 into develop Apr 25, 2023
4 checks passed
@snipe snipe deleted the fixes/finer_permissions_for_bulk_assets branch April 25, 2023 15:09
@what-the-diff
Copy link

what-the-diff bot commented Apr 25, 2023

PR Summary

  • Changed edit function to use view permission
    The edit function now checks for view permission, rather than update permission, to allow more appropriate access control.
  • Added view permission check for labels
    View permission checks have been added for labels, ensuring proper access management.
  • Added permission checks for delete and restore cases
    Delete and restore cases now check for the respective permissions (delete and update), improving security and access control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant